Send rejoin packets on conference disconnection #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
previously approved these changes
Sep 20, 2018
zugz
force-pushed
the
rejoinOnFreeze
branch
from
1c43cd0
to
f42dbe7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1192 +/- ##
========================================
+ Coverage 82.8% 82.9% +<.1%
========================================
Files 82 82
Lines 14637 14641 +4
========================================
+ Hits 12133 12148 +15
+ Misses 2504 2493 -11
Continue to review full report at Codecov.
|
iphydf
approved these changes
Sep 20, 2018
zugz
force-pushed
the
rejoinOnFreeze
branch
from
f42dbe7
to
f91358a
Compare
We were mistakenly not making a rejoin attempt on freezing connections due to all closest connections going down. This fixes that, and tweaks the test. I've still only done tens rather than hundreds of tests, but I'm fairly confident that the conference test now consistently passes.
zugz
force-pushed
the
rejoinOnFreeze
branch
from
f91358a
to
e43b2ea
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were mistakenly not making a rejoin attempt on freezing connections due to
all closest connections going down. This fixes that, and tweaks the test. I've
still only done tens rather than hundreds of tests, but I'm fairly confident
that the conference test now consistently passes.
This change is