Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in comments and log and test assertion messages. #1187

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Fix typos in comments and log and test assertion messages. #1187

merged 1 commit into from
Sep 19, 2018

Conversation

yangfl
Copy link

@yangfl yangfl commented Sep 19, 2018

This change is Reviewable

Copy link
Member

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 13 of 13 files at r1.
Reviewable status: 0 of 1 approvals obtained

@iphydf iphydf added this to the v0.2.x milestone Sep 19, 2018
@iphydf iphydf changed the title Fix typos Fix typos in comments and log and test assertion messages. Sep 19, 2018
@codecov
Copy link

codecov bot commented Sep 19, 2018

Codecov Report

Merging #1187 into master will decrease coverage by 0.2%.
The diff coverage is 33.3%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1187     +/-   ##
========================================
- Coverage    82.8%   82.5%   -0.3%     
========================================
  Files          82      82             
  Lines       14637   14637             
========================================
- Hits        12124   12089     -35     
- Misses       2513    2548     +35
Impacted Files Coverage Δ
toxcore/onion.c 98.7% <ø> (ø) ⬆️
toxcore/DHT.c 76.6% <ø> (ø) ⬆️
testing/misc_tools.c 55.1% <ø> (ø) ⬆️
toxav/rtp.c 72.6% <ø> (ø) ⬆️
auto_tests/TCP_test.c 100% <ø> (ø) ⬆️
toxcore/crypto_core_test.cc 90.3% <0%> (ø) ⬆️
toxav/toxav.c 67.3% <100%> (-1%) ⬇️
auto_tests/network_test.c 90.3% <0%> (-7.3%) ⬇️
auto_tests/toxav_many_test.c 92.5% <0%> (-4.1%) ⬇️
auto_tests/toxav_basic_test.c 81.6% <0%> (-2%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 758bd9a...d3d5b70. Read the comment docs.

@iphydf iphydf merged commit d3d5b70 into TokTok:master Sep 19, 2018
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.8 Oct 7, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants