Fixed a silly boolean practice using uint8_t #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
requested changes
Sep 16, 2018
toxcore/Messenger.c
Outdated
| @@ -2590,8 +2590,8 @@ uint32_t messenger_run_interval(const Messenger *m) | |||
| void do_messenger(Messenger *m, void *userdata) | |||
| { | |||
| // Add the TCP relays, but only if this is the first time calling do_messenger | |||
| if (m->has_added_relays == 0) { | |||
| m->has_added_relays = 1; | |||
| if (!(m->has_added_relays)) { | |||
hugbubby
force-pushed
the
silly-bool
branch
from
512eef6
to
889e89b
Compare
iphydf
approved these changes
Sep 16, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very small two line change, this bool/if statement was written in a very convoluted way.
This change is