Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use most recent version of Bazel (0.17.1). #1161

Merged
merged 1 commit into from
Sep 15, 2018
Merged

Use most recent version of Bazel (0.17.1). #1161

merged 1 commit into from
Sep 15, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Sep 14, 2018 •
edited
Loading

This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Sep 14, 2018
@nurupo
Copy link
Member

nurupo commented Sep 14, 2018 •
edited
Loading

external/opus/src/opus_decoder.c:37:10:warning:You appear to be compiling without optimization, if so opus will be very slow.

nurupo
nurupo approved these changes Sep 14, 2018
View reviewed changes
Copy link
Member

@nurupo nurupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained

@iphydf iphydf merged commit e0f9f2f into TokTok:master Sep 15, 2018
@iphydf iphydf deleted the upgrade-bazel branch September 15, 2018 08:17
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.8 Oct 7, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nurupo nurupo nurupo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.8
Development

Successfully merging this pull request may close these issues.
3 participants
@iphydf @nurupo @robinlinden