Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid recursion in ip_is_lan and ip_is_local. #1139

Merged
merged 1 commit into from
Sep 7, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Aug 27, 2018

This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Aug 27, 2018
@codecov
Copy link

codecov bot commented Aug 27, 2018

Codecov Report

Merging #1139 into master will decrease coverage by 0.2%.
The diff coverage is 72.7%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1139     +/-   ##
========================================
- Coverage    82.9%   82.6%   -0.3%     
========================================
  Files          82      82             
  Lines       14594   14476    -118     
========================================
- Hits        12104   11971    -133     
- Misses       2490    2505     +15
Impacted Files Coverage Δ
toxcore/LAN_discovery.c 84.9% <72.7%> (ø) ⬆️
auto_tests/network_test.c 90.3% <0%> (-7.3%) ⬇️
toxcore/group.c 73.2% <0%> (-2.9%) ⬇️
auto_tests/conference_test.c 97.7% <0%> (-1.5%) ⬇️
toxcore/net_crypto.c 92.7% <0%> (-1.5%) ⬇️
toxcore/onion_client.c 94.5% <0%> (-1.4%) ⬇️
toxcore/friend_connection.c 94.5% <0%> (-0.3%) ⬇️
toxcore/DHT.c 76.7% <0%> (-0.1%) ⬇️
toxcore/tox.c 65.7% <0%> (-0.1%) ⬇️
auto_tests/run_auto_test.h 100% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f59e6ff...1cd1836. Read the comment docs.

@iphydf iphydf merged commit 1cd1836 into TokTok:master Sep 7, 2018
@iphydf iphydf deleted the ip-is-lan-norec branch September 7, 2018 14:46
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.8 Oct 7, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants