Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the tsan build fail instead of swallowing its errors. #1133

Merged
merged 1 commit into from
Aug 26, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Aug 26, 2018

We'll make it non-required, but we want to know about these failures so
we are incentivised to fix them.


This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 26, 2018

Codecov Report

Merging #1133 into master will decrease coverage by <.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1133     +/-   ##
========================================
- Coverage    82.6%   82.5%   -0.1%     
========================================
  Files          81      81             
  Lines       14437   14414     -23     
========================================
- Hits        11929   11904     -25     
- Misses       2508    2510      +2
Impacted Files Coverage Δ
toxav/msi.c 64.2% <0%> (-2.6%) ⬇️
toxcore/friend_connection.c 93.6% <0%> (-0.9%) ⬇️
toxcore/DHT.c 76.6% <0%> (-0.9%) ⬇️
toxcore/network.c 83.4% <0%> (-0.3%) ⬇️
toxav/toxav.c 68.5% <0%> (-0.2%) ⬇️
toxcore/Messenger.c 85.7% <0%> (-0.1%) ⬇️
toxcore/mono_time_test.cc 100% <0%> (ø) ⬆️
toxcore/net_crypto.c 93.1% <0%> (ø) ⬆️
toxcore/LAN_discovery.c 84.9% <0%> (+2.8%) ⬆️
toxcore/mono_time.c 100% <0%> (+7.1%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01e2cc5...5352f48. Read the comment docs.

We'll make it non-required, but we want to know about these failures so
we are incentivised to fix them.
@iphydf iphydf merged commit 5352f48 into TokTok:master Aug 26, 2018
@iphydf iphydf deleted the fail-tsan branch August 26, 2018 20:41
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.7 Aug 30, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants