Simplify configure.ac for faster autotools build. #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1126 +/- ##
========================================
+ Coverage 82.5% 82.6% +<.1%
========================================
Files 82 81 -1
Lines 14478 14437 -41
========================================
- Hits 11957 11931 -26
+ Misses 2521 2506 -15
Continue to review full report at Codecov.
|
zugz
requested changes
Aug 26, 2018
| # Checks for library functions. | ||
| AC_FUNC_FORK | ||
| AC_CHECK_FUNCS([gettimeofday memset socket strchr malloc]) |
There was a problem hiding this comment.
It does seem these tests aren't used. But meanwhile it seems we should be testing (with AC_CHECK_FUNCS) for memset_s and explicit_bzero. CMakeLists checks for them, and crypto_core_mem.c uses the defines.
iphydf
force-pushed
the
simplify-autotools
branch
from
be90c83
to
b99e9d5
Compare
|
Done. |
iphydf
force-pushed
the
simplify-autotools
branch
from
b99e9d5
to
dd4eb6d
Compare
|
@zugz lgtm? |
zugz
approved these changes
Aug 27, 2018
iphydf
force-pushed
the
simplify-autotools
branch
from
dd4eb6d
to
63899e8
Compare
* Remove ability to disable logging. * Remove unused `NCURSES_FOUND`. * Remove checks for stdbool and existence of int types. These mostly exist, and if they don't, we'll just fail to compile. * Remove checks for various functions. * Add check for `explicit_bzero` and `memset_s`.
iphydf
force-pushed
the
simplify-autotools
branch
from
63899e8
to
36f0caa
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NCURSES_FOUND.These mostly exist, and if they don't, we'll just fail to compile.
This change is