Fix auto_tests Makefile #1112
Merged
Fix auto_tests Makefile #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I'm only semi happy with the desire to keep the test lists in sync. Sometimes tests take a lot of time and autotools doesn't have a timeout. I guess we should look into the root cause and fix it. Other than that no particular concerns. |
iphydf
approved these changes
Aug 22, 2018
|
I'm only semi happy with the desire to keep the test lists in sync.
I take it you're referring to setting check_PROGRAMS = $(TESTS). We can
always separate them again if that turns out to be appropriate (though
actually I don't see why it would be - based on
https://www.gnu.org/software/automake/manual/html_node/Scripts_002dbased-Testsuites.html#Scripts_002dbased-Testsuites
it looks like they ought to be equal?).
Meanwhile, I'm stumped as to what's going on with the travis build
failure https://travis-ci.org/TokTok/c-toxcore/jobs/419265294 .
I can't reproduce it on my machine.
|
Codecov Report
@@ Coverage Diff @@
## master #1112 +/- ##
========================================
- Coverage 82.6% 82.5% -0.2%
========================================
Files 80 80
Lines 14318 14318
========================================
- Hits 11840 11819 -21
- Misses 2478 2499 +21
Continue to review full report at Codecov.
|
iphydf
force-pushed
the
testsMakefileFixes
branch
2 times, most recently
from
6448ec4
to
549c3ab
Compare
zugz
force-pushed
the
testsMakefileFixes
branch
3 times, most recently
from
10e0b8b
to
89cfb16
Compare
* specify correct source files * add save_compatibility_test (commented out for now) * reformat TESTS to one line per test, and set check_PROGRAMS := TESTS * add run_auto_test.h to EXTRA_DIST * Fix `AUTO_TEST_CFLAGS` -> `AUTOTEST_CFLAGS`.
zugz
force-pushed
the
testsMakefileFixes
branch
from
89cfb16
to
efcda6c
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify correct sources, add missing test save_compatability_test, and make the
list of tests easier to edit (one line per test, not repeated).
This change is