Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable .travis.yml check and use non-markdown license. #1096

Merged
merged 1 commit into from
Aug 18, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Aug 17, 2018

This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Aug 17, 2018
@nurupo
Copy link
Member

nurupo commented Aug 18, 2018

Undoing the License Markdown conversion you did in all/most of TokTok several weeks ago. I do like plain text licenses better, but why did you change your mind?

Also, you say "Enable .travis.yml check" but I don't see where you have enabled it in the diff. Did you mean to say something along the lines "Format .travis.yml with Travis'es linter/formatter" in the commit message? Unless you have Travis'es linter enabled in //tools/project:build_defs.bzl file, but where is this path even pointing to, it doesn't seem to be in this repo, is that a file from TokTok Stack repo?

@iphydf
Copy link
Member Author

iphydf commented Aug 18, 2018

s/several weeks/6 months/.

Main reason: most people don't use markdown license in their repo, so I don't want to enforce that for repos entering the toktok org.
Secondary reason: github recognises the non-markdown version and shows it on the main page of the repo.

Copy link
Member

@robinlinden robinlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 4 of 4 files at r1.
Reviewable status: 0 of 1 approvals obtained

@iphydf iphydf merged commit fc7a5dc into TokTok:master Aug 18, 2018
@iphydf iphydf deleted the license-check branch August 18, 2018 23:33
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.7 Aug 30, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants