-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use test clock in run_auto_test tests and dht test #1095
Conversation
69bf11e
to
c29179d
Compare
Looks good. Can you make the first commit ("make mono_time an argument") a separate PR? |
Can you also make the "rename monotime to mono_time" a separate PR? |
1779481
to
a68d023
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 11 files at r1.
Reviewable status: 0 of 1 approvals obtained
Codecov Report
@@ Coverage Diff @@
## master #1095 +/- ##
========================================
+ Coverage 82.6% 83% +0.3%
========================================
Files 82 82
Lines 14478 14473 -5
========================================
+ Hits 11970 12014 +44
+ Misses 2508 2459 -49
Continue to review full report at Codecov.
|
This lets us test behaviours which involve timeouts without actually waiting
for the timeout to occur in realtime.
Based on #1038.
(This PR converts a few of the tests to use this facility; handling the
remainder is left to future work.)
This change is