Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set _POSIX_C_SOURCE to 200112L. We need it for C99 compat. #1094

Merged
merged 1 commit into from
Aug 18, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Aug 17, 2018

It is invalid to compile an XPG3, XPG4, XPG4v2, or XPG5 application
using c99. The same is true for POSIX.1-1990, POSIX.2-1992, POSIX.1b,
and POSIX.1c applications. Likewise, it is invalid to compile an XPG6
or a POSIX.1-2001 application with anything other than a c99 or later
compiler. Therefore, Solaris libc forces an error in both cases.


This change is Reviewable

iphydf added a commit to iphydf/pkgsrc that referenced this pull request Aug 17, 2018
Added a patch that's upstreamed in TokTok/c-toxcore#1094.
iphydf added a commit to iphydf/pkgsrc that referenced this pull request Aug 17, 2018
Added a patch that's upstreamed in TokTok/c-toxcore#1094.
Copy link
Member

@robinlinden robinlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained

It is invalid to compile an XPG3, XPG4, XPG4v2, or XPG5 application
using c99.  The same is true for POSIX.1-1990, POSIX.2-1992, POSIX.1b,
and POSIX.1c applications. Likewise, it is invalid to compile an XPG6
or a POSIX.1-2001 application with anything other than a c99 or later
compiler.  Therefore, Solaris libc forces an error in both cases.
@iphydf iphydf merged commit 9fb8705 into TokTok:master Aug 18, 2018
@iphydf iphydf deleted the posix-2001 branch August 18, 2018 18:10
@iphydf iphydf added this to the v0.2.x milestone Aug 19, 2018
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.7 Aug 30, 2018
iphydf added a commit to iphydf/pkgsrc that referenced this pull request Aug 30, 2018
Added a patch that's upstreamed in TokTok/c-toxcore#1094.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants