Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style in bwcontroller module. #1076

Merged
merged 1 commit into from
Aug 12, 2018
Merged

Fix style in bwcontroller module. #1076

merged 1 commit into from
Aug 12, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Aug 12, 2018

  • Comments in macros must be // style.
  • No inner structs.
  • Named callback types.
  • ++i instead of i++.
  • No assignments as expressions.

This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Aug 12, 2018
@iphydf iphydf requested a review from zoff99 August 12, 2018 16:10
Copy link
Member

@robinlinden robinlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 2 of 2 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @zoff99)

* Comments in macros must be `//` style.
* No inner structs.
* Named callback types.
* `++i` instead of `i++`.
* No assignments as expressions.
@iphydf iphydf merged commit b2590e2 into TokTok:master Aug 12, 2018
@iphydf iphydf deleted the bwc-style branch August 12, 2018 18:37
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.6 Aug 14, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants