Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FreeBSD VM on Travis not shutting down #1075

Merged
merged 2 commits into from
Aug 27, 2018

Conversation

nurupo
Copy link
Member

@nurupo nurupo commented Aug 12, 2018

Proper fix for #1071.


This change is Reviewable

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

iphydf
iphydf previously approved these changes Aug 12, 2018
Copy link
Member

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewable status: 0 of 1 approvals obtained

@iphydf iphydf added this to the v0.2.x milestone Aug 12, 2018
@nurupo nurupo force-pushed the travis-freebsd-poweroff-fix branch from caf4570 to f17539a Compare August 27, 2018 03:25
@nurupo nurupo force-pushed the travis-freebsd-poweroff-fix branch from f17539a to 8d5c100 Compare August 27, 2018 05:51
@codecov
Copy link

codecov bot commented Aug 27, 2018

Codecov Report

Merging #1075 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1075     +/-   ##
========================================
- Coverage    82.6%   82.5%   -0.2%     
========================================
  Files          81      81             
  Lines       14437   14437             
========================================
- Hits        11935   11916     -19     
- Misses       2502    2521     +19
Impacted Files Coverage Δ
toxcore/crypto_core_test.cc 90.3% <0%> (-9.7%) ⬇️
toxcore/friend_connection.c 93.6% <0%> (-2.1%) ⬇️
toxcore/net_crypto.c 93.1% <0%> (-0.5%) ⬇️
toxcore/onion_client.c 95% <0%> (-0.4%) ⬇️
toxcore/Messenger.c 85.7% <0%> (-0.3%) ⬇️
toxcore/LAN_discovery.c 84.9% <0%> (+0.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a70a2c...25a477a. Read the comment docs.

@nurupo nurupo force-pushed the travis-freebsd-poweroff-fix branch from 8d5c100 to 25a477a Compare August 27, 2018 09:05
@nurupo nurupo changed the title [WIP] Travis freebsd poweroff fix Fix FreeBSD VM on Travis not shutting down Aug 27, 2018
@nurupo
Copy link
Member Author

nurupo commented Aug 27, 2018

@iphydf should be fixed now. Travis-CI passes, Circle-CI tsan fails.

@iphydf
Copy link
Member

iphydf commented Aug 27, 2018

Thanks, I don't know why coveralls is complaining.

@iphydf iphydf merged commit 25a477a into TokTok:master Aug 27, 2018
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.7 Aug 30, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants