Avoid forward declaration of rtp structs. #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
no-forward-decls
branch
from
b0faa46
to
8dacc64
Compare
Forward declarations are problematic, as they easily allow introducing cyclic dependencies.
iphydf
force-pushed
the
no-forward-decls
branch
from
8dacc64
to
767ccbb
Compare
zoff99
approved these changes
Aug 12, 2018
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: 0 of 1 approvals obtained
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward declarations are problematic, as they easily allow introducing
cyclic dependencies.
This change is