Fix ToxAv's use of struct Tox.
#1064
Conversation
iphydf
force-pushed
the
toxav-get-tox
branch
3 times, most recently
from
a1a9b19
to
71f66d8
Compare
iphydf
changed the title
toxav_get_tox to return tox, not messenger.struct Tox.
iphydf
force-pushed
the
toxav-get-tox
branch
2 times, most recently
from
ddc3b60
to
30d6976
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained (waiting on @zoff99)
toxav/video.c, line 348 at r1 (raw file):
for (vpx_image_t *dest = vpx_codec_get_frame(vc->decoder, &iter); dest != nullptr; dest = vpx_codec_get_frame(vc->decoder, &iter)) {
be very careful with this loop. it works against common logic. i ran into problems here before. tbh i would not change this one for the moment, and just mark it TODO.
this needs to be tested with Video tests, to see if u are getting double or empty frames.
iphydf
force-pushed
the
toxav-get-tox
branch
14 times, most recently
from
d07c736
to
01e2eac
Compare
* Fix `toxav_get_tox` to return tox, not messenger. * Fix the casts from Tox* to Messenger* in toxav_old.c. * Pass Tox instead of Messenger to public group AV callbacks.
There was a problem hiding this comment.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @zoff99)
toxav/video.c, line 348 at r1 (raw file):
Previously, zoff99 (Zoff) wrote…
be very careful with this loop. it works against common logic. i ran into problems here before. tbh i would not change this one for the moment, and just mark it TODO.
this needs to be tested with Video tests, to see if u are getting double or empty frames.
Moved it out to a different PR.
iphydf
dismissed
zoff99’s stale review
The code this comment was about has moved to a different PR.
This change is