Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force storing the result of crypto_memcmp in the test. #1061

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Aug 11, 2018

So we don't accidentally elide the call given that it's a pure function
and its result isn't used.


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Aug 11, 2018
@iphydf iphydf force-pushed the store-memcmp-result branch 3 times, most recently from f1b2c58 to 36286fb Compare August 15, 2018 00:24
Copy link
Member

@robinlinden robinlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained

So we don't accidentally elide the call given that it's a pure function
and its result isn't used.
@codecov
Copy link

codecov bot commented Aug 23, 2018

Codecov Report

Merging #1061 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1061     +/-   ##
========================================
+ Coverage    82.4%   82.6%   +0.2%     
========================================
  Files          80      80             
  Lines       14317   14318      +1     
========================================
+ Hits        11801   11840     +39     
+ Misses       2516    2478     -38
Impacted Files Coverage Δ
toxcore/crypto_core_test.cc 90.3% <100%> (+0.3%) ⬆️
toxcore/net_crypto.c 93.3% <0%> (-0.3%) ⬇️
toxcore/Messenger.c 86.2% <0%> (ø) ⬆️
toxav/toxav.c 68.8% <0%> (+1.1%) ⬆️
toxcore/group.c 73.1% <0%> (+1.4%) ⬆️
toxav/msi.c 66.7% <0%> (+2.2%) ⬆️
auto_tests/toxav_many_test.c 96.6% <0%> (+4%) ⬆️
auto_tests/typing_test.c 100% <0%> (+6%) ⬆️
auto_tests/set_name_test.c 100% <0%> (+6.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2730c95...ff342a5. Read the comment docs.

@iphydf iphydf merged commit ff342a5 into TokTok:master Aug 23, 2018
@iphydf iphydf deleted the store-memcmp-result branch August 23, 2018 22:43
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.7 Aug 30, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants