Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in loop over assocs. #1056

Merged
merged 1 commit into from
Aug 10, 2018
Merged

Fix typo in loop over assocs. #1056

merged 1 commit into from
Aug 10, 2018

Conversation

zugz
Copy link

@zugz zugz commented Aug 8, 2018

(introduced by #1041)


This change is Reviewable

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@iphydf iphydf changed the title fix typo in loop over assocs Fix typo in loop over assocs. Aug 9, 2018
@iphydf iphydf merged commit afab28f into TokTok:master Aug 10, 2018
iphydf referenced this pull request Aug 12, 2018
All for-loops in toxcore are of the form

    for (<for-init>; <for-cond>; <for-next>) { <body> }

`for-init` can be a variable declaration (like `int i = 0`), an
assignment (like `i = 0`), or empty.

`for-cond` can be any expression.

`for-next` can be an assignment or a single increment/decrement
expression (like `++i` or `--i`).

No other forms are allowed, so e.g. comma expressions in any of these are
not allowed (so no `for (i = 0, j = n; ...; ++i, --j)`).
@iphydf iphydf added this to the v0.2.x milestone Aug 12, 2018
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.6 Aug 14, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants