-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tokstyle in the cmake travis build. #1053
Conversation
dd9377d
to
3098874
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 LGTMs obtained
.travis/cmake-linux, line 12 at r1 (raw file):
travis_install() { curl -L https://github.com/TokTok/hs-tools/releases/download/v0.2/hs-tools-v0.2.tar.gz | tar xz -C $HOME
Instead of doing this, we can do the following:
-
Use the github api to automatically get the latest release for the tokstyle tool, so we don't have to update this file every release.
Solution here: https://stackoverflow.com/questions/24085978/github-url-for-latest-release-of-the-download-file -
Create releases for the tokstyle tool and automatically download that package (and whatever hs-tools we believe we need in the future) rather than gather them up in this hs-tools repo and download that.
We're not an operating system - we will solve more problems by doing rolling release than by wasting time gathering them up into a single hs-tools repo package and testing that beforehand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 LGTMs obtained
.travis/cmake-linux, line 12 at r1 (raw file):
Previously, hugbubby wrote…
Instead of doing this, we can do the following:
Use the github api to automatically get the latest release for the tokstyle tool.
Solution here: https://stackoverflow.com/questions/24085978/github-url-for-latest-release-of-the-download-fileCreate releases for the tokstyle tool and automatically download that package rather than gather them up in this hs-tools repo and download that.
We're not an operating system - we will solve more problems by doing rolling release than by wasting time gathering them up into a single hs-tools repo package and testing that beforehand.
I like this idea. I'd still like to do this for now, and then change this repo together with all the haskell repos so they behave the same. The hs-tools repo will stay, because we want to build some tools that aren't developed by us there.
I'll make a PR into tokstyle to make releases, but I don't want that to block the adoption of tokstyle into the c-toxcore build, since without it, I have to manually run it on every PR.
3279637
to
0ca341b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 LGTMs obtained
.travis/cmake-linux, line 12 at r1 (raw file):
Previously, iphydf wrote…
I like this idea. I'd still like to do this for now, and then change this repo together with all the haskell repos so they behave the same. The hs-tools repo will stay, because we want to build some tools that aren't developed by us there.
I'll make a PR into tokstyle to make releases, but I don't want that to block the adoption of tokstyle into the c-toxcore build, since without it, I have to manually run it on every PR.
Done.
d30ed5d
to
9283be7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: complete! 1 of 1 approvals obtained
This checks that (some of) the code follows some simplicity and naming guidelines set by the tool.
This checks that (some of) the code follows some simplicity and naming
guidelines set by the tool.
This change is