Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all tests in the Autotools build #1037

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Conversation

hugbubby
Copy link
Member

@hugbubby hugbubby commented Jul 29, 2018

Mosts of the tests in auto_tests weren't running when the project
was built using autotools. This fixes that.


This change is Reviewable

Copy link
Member

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong: though it was intentional to not have all the tests in the autotools build.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@hugbubby
Copy link
Member Author

hugbubby commented Jul 29, 2018

Hold up - edited the makefile wrong. I wrote a script that copied and added all the tests into the makefile XP

@hugbubby hugbubby force-pushed the build-issues branch 3 times, most recently from c311328 to be2c0f6 Compare July 29, 2018 00:18
Mosts of the tests in auto_tests weren't running when the project
was built using autotools. This fixes that.
@iphydf iphydf merged commit 3a4987d into TokTok:master Jul 31, 2018
@iphydf iphydf changed the title Update Autotools build Run all tests in the Autotools build Jul 31, 2018
@iphydf iphydf modified the milestones: v0.2.x, v0.2.5 Aug 4, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants