Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronise parameter names in headers with those in the implementation. #1019

Merged
merged 1 commit into from
Jul 21, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jul 19, 2018

This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Jul 19, 2018
@zugz
Copy link

zugz commented Jul 20, 2018 via email

Copy link
Member

@robinlinden robinlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! 2 of 1 LGTMs obtained

@iphydf iphydf merged commit b6b3cdb into TokTok:master Jul 21, 2018
@iphydf iphydf deleted the parameter-names branch July 21, 2018 14:56
@iphydf iphydf modified the milestones: v0.2.x, v0.2.5 Aug 4, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants