Apidsl fixes and start tracking test coverage

[iphydf]

This change is

[coveralls]

Changes Unknown when pulling 71860a3 on iphydf:master into * on TokTok:master*.

[coveralls]

Changes Unknown when pulling 071b4b3 on iphydf:master into * on TokTok:master*.

[coveralls]

Changes Unknown when pulling 071b4b3 on iphydf:master into * on TokTok:master*.

[nurupo]

@iphydf any reason why @DeriveFH (irungentoo#1542) is not attributed for Fixes for apidsl?

[nurupo]

Review status: 0 of 3 files reviewed at latest revision, 4 unresolved discussions.

---

.travis.yml, line 2 [r1] (raw file):

sudo: required
dist: trusty

Why are we switching Travis away from using Ubuntu 14.04 to Ubuntu 12.04? https://docs.travis-ci.com/user/ci-environment/#Virtualization-environments

Ubuntu 14.04 has libconfig-dev, libvpx-dev, libopus-dev and check in it's package repos, which eliminates all the building you do below in this file.

---

.travis.yml, line 17 [r1] (raw file):

cache:
  directories:
    - $HOME/cache

Hm, you want to cache all the builds to save time it takes for Travis to run? It looks okay.

---

.travis.yml, line 73 [r1] (raw file):

        cd ..
      }
  - popd

Most of this building is not necessary if Ubuntu 14.04 is used.

---

.travis.yml, line 90 [r1] (raw file):

        CFLAGS="-O0 -Wall -Wextra -fprofile-arcs -ftest-coverage"
  - make
  - make check || true

Doesn't Travis already fail a build if any of commands exit with non 0 code?

---

Comments from Reviewable

[nurupo]

Review status: 0 of 3 files reviewed at latest revision, 4 unresolved discussions.

---

.travis.yml, line 90 [r1] (raw file):

Previously, nurupo wrote…

Doesn't Travis already fail a build if any of commands exit with non 0 code?

Ok, misread this. So, we ignore the exit code of the testing?

---

Comments from Reviewable

[iphydf]

I didn't know that PR existed when I made my changes, but I'm happy to incorporate commits from there. I'll back out my changes.

---

Review status: 0 of 3 files reviewed at latest revision, 4 unresolved discussions.

---

.travis.yml, line 2 [r1] (raw file):

Previously, nurupo wrote…

Why are we switching Travis away from using Ubuntu 14.04 to Ubuntu 12.04? https://docs.travis-ci.com/user/ci-environment/#Virtualization-environments

Ubuntu 14.04 has libconfig-dev, libvpx-dev, libopus-dev and check in it's package repos, which eliminates all the building you do below in this file.

This is because sudo enabled builds don't support caching. It saves quite a lot of time to avoid building apidsl dependencies and libsodium every time.

---

.travis.yml, line 17 [r1] (raw file):

Previously, nurupo wrote…

Hm, you want to cache all the builds to save time it takes for Travis to run? It looks okay.

Indeed.

---

.travis.yml, line 73 [r1] (raw file):

Previously, nurupo wrote…

Most of this building is not necessary if Ubuntu 14.04 is used.

Correct, but the building is mitigated by caching which is not available on 14.04.

---

.travis.yml, line 90 [r1] (raw file):

Previously, nurupo wrote…

Ok, misread this. So, we ignore the exit code of the testing?

Yes, we ignore test outcome because it fails. The first thing we need to do after this is to fix the test and stop ignoring its failure.

---

Comments from Reviewable

[nurupo]

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.

---

.travis.yml, line 73 [r1] (raw file):

Previously, iphydf wrote…

Correct, but the building is mitigated by caching which is not available on 14.04.

This page says that caching is available in 14.04 https://docs.travis-ci.com/user/ci-environment/#Virtualization-environments

I guess whether it's available or not doesn't matter because the boot time for 14.04 is way slower than for the container 12.04.

---

Comments from Reviewable

[iphydf]

@yashikno I've merged your changes here. Thanks for making them.

[coveralls]

Changes Unknown when pulling 83f5258 on iphydf:master into * on TokTok:master*.

[iphydf]

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.

---

.travis.yml, line 73 [r1] (raw file):

Previously, nurupo wrote…

This page says that caching is available in 14.04 https://docs.travis-ci.com/user/ci-environment/#Virtualization-environments

I guess whether it's available or not doesn't matter because the boot time for 14.04 is way slower than for the container 12.04.

Amended the commit message.

---

Comments from Reviewable

[nurupo]

How/where is the 60% of code coverage enforced?

[iphydf]

Unfortunately, that is currently only set on the coveralls settings page. I hope to get codecov.io submission working at some point, and then the setting is in a codecov.yml file.

[nurupo]

Reviewed 1 of 3 files at r1, 2 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[nurupo]

Hm, reviewable shows me a "Merge & Retain Branch", which is interesting as I shouldn't have permissions to push into this repo.

[nurupo]

Yet GitHub says

I guess reviewable doesn't check if I have permission until I try to merge through its web UI and GitHub API returns an error.