Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake can't detect and compile ToxAV on OSX #482

Closed
GrayHatter opened this issue Feb 20, 2017 · 4 comments · Fixed by #483
Closed

CMake can't detect and compile ToxAV on OSX #482

GrayHatter opened this issue Feb 20, 2017 · 4 comments · Fixed by #483
Assignees
@cebe
Labels
P0 Critical priority toxav Audio/video
Milestone
v0.1.9

Comments

@GrayHatter
Copy link

CMake thinks VPX or OPUS can't be found on OSX so it ignores and/or over-rides -DBUILD_TOXAV=ON.

Either way, the CMake file shouldn't ignore it's instructions, when -DBUILD_TOXAV is set to ON, it shouldn't decide it doesn't want to. Regardless of if it thinks VPX and OPUS is available.
@jhert0 jhert0 added toxav Audio/video P0 Critical priority labels Feb 20, 2017
cebe added a commit to cebe/c-toxcore that referenced this issue Feb 20, 2017
@cebe
make BUILD_TOXAV and option and fail if dependencies are missing
4cb6e4b 
fixes TokTok#482
@cebe cebe added this to the v0.1.7 milestone Feb 20, 2017
@cebe cebe mentioned this issue Feb 20, 2017
Merged
@cebe
Copy link
Member

cebe commented Feb 20, 2017

#483 should fix that.

cebe added a commit to cebe/c-toxcore that referenced this issue Mar 5, 2017
@cebe
make BUILD_TOXAV and option and fail if dependencies are missing
58160ca 
fixes TokTok#482
cebe added a commit to cebe/c-toxcore that referenced this issue Mar 6, 2017
@cebe
make BUILD_TOXAV and option and fail if dependencies are missing
ee5895c 
fixes TokTok#482
cebe added a commit to cebe/c-toxcore that referenced this issue Mar 25, 2017
@cebe
make BUILD_TOXAV and option and fail if dependencies are missing
a1f9df4 
fixes TokTok#482
@cebe
Copy link
Member

cebe commented Mar 26, 2017 •
edited
Loading

The finding issue is not fixed, just the error message got better. #483 (comment)

@cebe cebe reopened this Mar 26, 2017
@cebe cebe self-assigned this Mar 26, 2017
@cebe cebe modified the milestones: v0.1.8, v0.1.7 Mar 26, 2017
@GrayHatter
Copy link
Author

@cebe I was able to fix the issue by forcing a working version of pkg-config.

Up to you if you want to leave this issue open, per the comment in #483, I still think we should be able to override cmake from the cmdline

@iphydf iphydf modified the milestones: v0.1.8, v0.1.9 Apr 12, 2017
@GrayHatter
Copy link
Author

this is fixed

@iphydf iphydf added P3 Low priority and removed P3 Low priority labels Feb 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cebe cebe

Labels
P0 Critical priority toxav Audio/video
Projects
None yet
Milestone
v0.1.9
Development

Successfully merging a pull request may close this issue.

Make BUILD_TOXAV an option and fail if dependencies are missing cebe/c-toxcore
4 participants
@cebe @GrayHatter @iphydf @jhert0