Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate hstox tests with toxcore Travis build #4

Closed
iphydf opened this issue Jul 9, 2016 · 3 comments
Closed

Integrate hstox tests with toxcore Travis build #4

iphydf opened this issue Jul 9, 2016 · 3 comments
Assignees
Labels
help wanted Extra attention is needed P1 High priority
Milestone

Comments

@iphydf
Copy link
Member

iphydf commented Jul 9, 2016

This needs to do roughly:

cd .. # Get out of the toxcore clone (=> /home/travis).
git clone --recursive --depth=1 https://github.com/TokTok/hstox # Fetch hstox and its submodules.
rm -rf hstox/test/toxcore/toxcore # Remove the toxcore submodule
mv toxcore hstox/test/toxcore/ # Move the to-be-tested toxcore (from PR/branch) to the test directory.
cd hstox
make check-toxcore TEST=cov-asan # Build with coverage and address sanitizer.

This involves a bit more than just the above script:

  • Install ghc (>= 7.8). If downloading and installing ghc takes too much time, put it into $CACHE_DIR (~/cache).
  • Make two builds, one with BUILD=toxcore, one BUILD=hstox, and do different things on each. The toxcore build will do what the current build does, the hstox build does the above script. Both upload their coverage data.
iphydf added a commit to iphydf/hs-toxcore that referenced this issue Jul 9, 2016
iphydf added a commit to iphydf/hs-toxcore that referenced this issue Jul 9, 2016
iphydf added a commit to iphydf/hs-toxcore that referenced this issue Jul 9, 2016
iphydf added a commit to iphydf/hs-toxcore that referenced this issue Jul 9, 2016
iphydf added a commit to iphydf/hs-toxcore that referenced this issue Jul 9, 2016
iphydf added a commit to iphydf/hs-toxcore that referenced this issue Jul 9, 2016
iphydf added a commit to iphydf/hs-toxcore that referenced this issue Jul 9, 2016
iphydf added a commit to iphydf/hs-toxcore that referenced this issue Jul 9, 2016
@iphydf
Copy link
Member Author

iphydf commented Jul 11, 2016

@linux-modder are you going to work on this?

@iphydf iphydf added help wanted Extra attention is needed P1 High priority labels Jul 11, 2016
@GrayHatter GrayHatter added this to the Test Suite milestone Jul 12, 2016
@iphydf iphydf self-assigned this Jul 14, 2016
@iphydf
Copy link
Member Author

iphydf commented Jul 14, 2016

No activity here, so I'm doing it myself in #16.

@linux-modder
Copy link

Iphydf, I've been busy with other things too but feel free re-assigning it to yourself

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed P1 High priority
Projects
None yet
Development

No branches or pull requests

3 participants