Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reimplement the supervisor strategy #625

Merged
merged 2 commits into from
Feb 13, 2025
Merged

refactor: reimplement the supervisor strategy #625

merged 2 commits into from
Feb 13, 2025

Conversation

Tochemey
Copy link
Owner

The new implementation simplifies a lot the Supervision strategy and now we can support the following strategies:

  • OneForOne:
  • OneForAll

along side a clean Directives enum:

  • StopDirective
  • ResumeDirective
  • RestartDirective

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 93.15068% with 20 lines in your changes missing coverage. Please review.

Project coverage is 83.58%. Comparing base (056ddcd) to head (35b7b8a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
actor/pid.go 88.42% 10 Missing and 1 partial ⚠️
actor/pid_tree.go 92.10% 4 Missing and 2 partials ⚠️
actor/supervisor.go 95.52% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
+ Coverage   83.42%   83.58%   +0.15%     
==========================================
  Files         106      105       -1     
  Lines        9088     9160      +72     
==========================================
+ Hits         7582     7656      +74     
+ Misses       1160     1157       -3     
- Partials      346      347       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tochemey Tochemey merged commit 15a5c94 into main Feb 13, 2025
6 checks passed
@Tochemey Tochemey deleted the issue-x branch February 13, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant