Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup the code to allow easy extensibility #505

Merged
merged 14 commits into from
Oct 27, 2024
Merged

Conversation

Tochemey
Copy link
Owner

@Tochemey Tochemey commented Oct 27, 2024

  • Abstract remoting into a nice struct called Remoting for client communication
  • Use the new remoting struct in PID and ActorSystem to cleanly handle remoting call
  • Refactor the cluster client to accept concrete Node instance rather than mere array list of addresses. This help to tailor client connection appropriately to the given node
  • Ensure that every http client connection closes appropriately to avoid resource leakage.

@Tochemey Tochemey enabled auto-merge (squash) October 27, 2024 10:18
@Tochemey Tochemey disabled auto-merge October 27, 2024 10:19
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 90.14599% with 81 lines in your changes missing coverage. Please review.

Project coverage is 87.76%. Comparing base (7209b33) to head (35f9c93).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
actors/actor_system.go 81.61% 18 Missing and 7 partials ⚠️
actors/remoting.go 91.22% 15 Missing and 5 partials ⚠️
client/client.go 86.17% 8 Missing and 5 partials ⚠️
actors/redistribution.go 69.23% 8 Missing and 4 partials ⚠️
actors/scheduler.go 86.15% 6 Missing and 3 partials ⚠️
actors/pid.go 98.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #505      +/-   ##
==========================================
+ Coverage   87.40%   87.76%   +0.36%     
==========================================
  Files          45       46       +1     
  Lines        4294     4513     +219     
==========================================
+ Hits         3753     3961     +208     
- Misses        426      433       +7     
- Partials      115      119       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tochemey Tochemey merged commit 7296141 into main Oct 27, 2024
5 checks passed
@Tochemey Tochemey deleted the issue-ref branch October 27, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant