Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mTLS support for remote communication #504

Closed
wants to merge 10 commits into from
Closed

Conversation

Tochemey
Copy link
Owner

@Tochemey Tochemey commented Oct 26, 2024

  • Unit test the TLS based functions
  • Abstract remoting into a nice struct called Remoting for client communication
  • Add remoting option to all remoting-based methods both in PID and ActorSystem
  • Refactor the cluster client to accept concrete Node instance rather than mere array list of addresses. This help to tailor client connection appropriately to the given node
  • PeerState includes additional information called Certificate that help connect appropriately to the given peer. This hidden to the end-user :)
  • Ensure that every http client connection closes appropriately to avoid resource leakage.
  • Enhance ActorSystem option to allow setting a TLS configuration
  • Enhance cluster client Node option to allow setting a TLS configuration
  • Enhance remote scheduling to take into account mTLS

@Tochemey Tochemey changed the title feat: add mTLS support feat: add mTLS support for remote communication Oct 26, 2024
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 87.32984% with 121 lines in your changes missing coverage. Please review.

Project coverage is 87.23%. Comparing base (7209b33) to head (a505db1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
actors/actor_system.go 75.97% 27 Missing and 10 partials ⚠️
actors/remoting.go 86.04% 28 Missing and 8 partials ⚠️
actors/redistribution.go 69.38% 12 Missing and 3 partials ⚠️
client/client.go 86.17% 8 Missing and 5 partials ⚠️
actors/scheduler.go 84.48% 6 Missing and 3 partials ⚠️
client/node.go 83.63% 8 Missing and 1 partial ⚠️
actors/pid.go 98.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
- Coverage   87.40%   87.23%   -0.17%     
==========================================
  Files          45       47       +2     
  Lines        4294     4639     +345     
==========================================
+ Hits         3753     4047     +294     
- Misses        426      467      +41     
- Partials      115      125      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tochemey
Copy link
Owner Author

Tochemey commented Oct 26, 2024

This PR will not be merged in any time soon because as long as it is nice to have it one can also make use a good service mesh like istio or linkerd to secure communication between nodes.

@Tochemey Tochemey marked this pull request as draft October 27, 2024 09:45
Copy link

This pull is inactive since 14 days!
If there is no activity, it will be closed in two weeks.

You should take one of the following actions:

  • Manually close this PR if it is no longer relevant
  • Push new commits or comment if you have more information to share

@Tochemey Tochemey closed this Nov 10, 2024
@Tochemey Tochemey deleted the issue-499 branch November 17, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant