Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove NATs deprecated features #441

Merged
merged 1 commit into from
Aug 25, 2024
Merged

refactor: remove NATs deprecated features #441

merged 1 commit into from
Aug 25, 2024

Conversation

Tochemey
Copy link
Owner

closes #439

@Tochemey Tochemey enabled auto-merge (squash) August 25, 2024 22:25
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 10 lines in your changes missing coverage. Please review.

Project coverage is 86.00%. Comparing base (1c29b18) to head (30f2bfc).
Report is 1 commits behind head on main.

Files Patch % Lines
discovery/nats/discovery.go 70.58% 6 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
- Coverage   86.08%   86.00%   -0.09%     
==========================================
  Files          47       47              
  Lines        3537     3545       +8     
==========================================
+ Hits         3045     3049       +4     
- Misses        346      349       +3     
- Partials      146      147       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tochemey Tochemey disabled auto-merge August 25, 2024 22:38
@Tochemey Tochemey merged commit cf4b59f into main Aug 25, 2024
1 of 2 checks passed
@Tochemey Tochemey deleted the issue-439 branch August 25, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] refactor code to address deprecated features in NATS
1 participant