Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metric instrumentation #196

Merged
merged 3 commits into from
Dec 31, 2023
Merged

feat: add metric instrumentation #196

merged 3 commits into from
Dec 31, 2023

Conversation

Tochemey
Copy link
Owner

@Tochemey Tochemey commented Dec 30, 2023

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

Attention: 72 lines in your changes are missing coverage. Please review.

Comparison is base (f862fff) 90.18% compared to head (883c728) 88.97%.

❗ Current head 883c728 differs from pull request most recent head 8b7f606. Consider uploading reports for the commit 8b7f606 to get more accurate results

Files Patch % Lines
actors/pid.go 35.55% 26 Missing and 3 partials ⚠️
actors/actor_system.go 24.13% 20 Missing and 2 partials ⚠️
metric/actor_metric.go 68.08% 10 Missing and 5 partials ⚠️
metric/system_metric.go 72.72% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
- Coverage   90.18%   88.97%   -1.21%     
==========================================
  Files          42       44       +2     
  Lines        4667     4809     +142     
==========================================
+ Hits         4209     4279      +70     
- Misses        368      428      +60     
- Partials       90      102      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tochemey Tochemey marked this pull request as ready for review December 31, 2023 23:20
@Tochemey Tochemey merged commit f51555f into main Dec 31, 2023
1 check passed
@Tochemey Tochemey deleted the issue-170 branch December 31, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant