Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: complete refactoring of the code to account for cluster #80

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

Tochemey
Copy link
Owner

@Tochemey Tochemey commented Jul 3, 2024

  • Properly take into account cluster mode when sending command
  • Complete change how to create an entity
  • Complete change on how to send command to an entity
  • Remove the need of an Entity object
  • Remove the need of generic for EntityBehavior
  • Make eGo engine thread safe

@Tochemey Tochemey added the enhancement New feature or request label Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 75.24752% with 25 lines in your changes missing coverage. Please review.

Project coverage is 77.33%. Comparing base (e7ede34) to head (f7767f6).

Files Patch % Lines
engine.go 72.82% 17 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   77.14%   77.33%   +0.18%     
==========================================
  Files          21       20       -1     
  Lines        1536     1575      +39     
==========================================
+ Hits         1185     1218      +33     
- Misses        224      228       +4     
- Partials      127      129       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tochemey Tochemey merged commit ffa04da into main Jul 4, 2024
2 checks passed
@Tochemey Tochemey deleted the issue-v3 branch July 4, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant