-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compose 1.6 #251
Compose 1.6 #251
Conversation
Hi, Could you please tag a new version with a bump of Compose Plugin to rc02 ("upgrade compose to 1.6.0-rc02")? I encountered an issue with the latest tag (beta02) related to this problem: JetBrains/compose-multiplatform#4277 Thanks a lot, |
PreCompose also have the same issue, waiting koin to upgrade. |
@Tlaster Is there any GitHub issue filed for Koin or any active PR that we can track the progress on that side? |
Not yet, I think koin team has their own release plan. |
Hi, Also, the latest tag seems have an issue with the go back implementation : With beta02 I have crash when I do the go back gesture
No problem with the previous version. |
Can you check if you have compose material 1.6.0 as dependency? |
Juste |
Can you check if add compose material works for you? |
Same error |
Can you check if add |
Nop, same error with |
@Tlaster Its look like the class SeekableTransitionState<S>(
initialState: S
) : TransitionState<S>() { /* […] */ } Maybe you could tag a updated pre-release version based on your latest addition (ComposePlugin-rc02) ? |
Before I can push a new release based on compose 1.6.0-rc02 (which I cannot do right now since koin is still not updating its compose dependency version), can you provide a sample that can reproduce this issue? It works fine here. |
Hi try your branch too to confirm if it's my code or an incompatibility between versions. And I confirm it's because the precompose-beta02 code is on the beta02 tag of the ComposePlugin, but my code is based on the rc02 ComposePlugin. I can produce a sample code but IDK If it's really useful. Since the problem with koin is only with iOS, Its not a really a problem for me (my app is not in production right now). I will wait 👍 |
It's happening (soon) InsertKoinIO/koin#1634 (comment) |
Hi, I still have the issue with the latest rc01 version.
I'm on the latest 1.6.0 version |
To complete my comment : I also have a strange method resolution, in the documentation of SeekableTransitionState, we found this :
But in my Android Studio, I have : import androidx.compose.animation.core.SeekableTransitionState
And, when my application run, its obviously crash :
It's seems related to the 1.6.0 upgrade, but not sure why … |
Which version of compose you're using for the android project? |
@c4software I think accompanist might be the issue, 0.35.0-alpha is targeting compose 1.7, can you try version 0.34.0? |
Oh yes ! Thats the root cause ! Thanks a lot. |
Now navigate will navigate directly instead of waiting for transition.
Hi, With the addition of |
It is, you can just have a |
fix #197, #223