Add oxlint GitHub Actions workflow#11
Conversation
Caches node_modules keyed on package-lock.json so npm ci is skipped on hits. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughGitHub Actions ワークフロー 変更内容CI リントワークフロー
見積もりコードレビュー労力🎯 2 (Simple) | ⏱️ ~10 minutes 詩
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/lint.yml:
- Around line 19-21: The cache key currently only includes runner.os and the
lockfile hash (node-modules-${{ runner.os }}-${{ hashFiles('package-lock.json')
}}), which can cause stale node_modules to be restored when the workflow's
node-version changes; update the key to include the workflow's node-version
variable (the node-version configured at the top of the job, e.g.
matrix.node-version or whatever variable is used) — for example append -${{
matrix.node-version }} or -${{ steps.setup-node.outputs.node-version }} into the
key so it becomes node-modules-${{ runner.os }}-${{ matrix.node-version }}-${{
hashFiles('package-lock.json') }} ensuring caches are invalidated when
node-version changes.
- Around line 7-9: Job "oxlint" currently doesn't declare GITHUB_TOKEN
permissions; add a minimal permissions block to restrict token scope to what's
needed for actions/checkout and actions/cache. Update the "oxlint" job
definition to include a permissions stanza that at minimum sets contents: read
(and add packages: read if your cache uses package artifacts), so the workflow
only grants the least privilege required for actions/checkout and actions/cache.
- Around line 11-15: The workflow pins mutable action tags to immutable commit
SHAs: replace each occurrence of actions/checkout@v4, actions/setup-node@v4, and
actions/cache@v4 with their respective full 40-character commit SHAs (use the
SHAs from the action repositories corresponding to the v4 release) and add a
trailing comment with the original tag (e.g., # v4) for readability; ensure you
update all three usages in the lint.yml to use the SHA-pinned refs to restore
reproducibility and supply-chain safety.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1ff2f5c5-4888-4f66-b321-0db93c397764
📒 Files selected for processing (1)
.github/workflows/lint.yml
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Fixes Applied SuccessfullyFixed 1 file based on 2 of 3 CodeRabbit feedback items. Files modified:
Changes:
Deferred:
Commit: The latest autofix changes are on the |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Summary
.github/workflows/lint.ymlを追加し、push と pull_request でnpm run lint(oxlint) を実行node_modulesをpackage-lock.jsonのハッシュキーでキャッシュし、ヒット時はnpm ciをスキップTest plan
npm ciがスキップされることを確認🤖 Generated with Claude Code
Summary by CodeRabbit
リリースノート