Rename constructors and methods per Dart & Flutter naming conventions #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked by #18 |
…Hsl() -> .toHSLColor()
…& Flutter naming conventions
|
@WieFel Can you take a look at this? It has been pending review for a month. |
WieFel
approved these changes
Apr 15, 2022
calvintam236
added a commit
that referenced
this pull request
Apr 16, 2022
* refactor: rename TinyColor() -> TinyColor.fromColor() * refactor: rename TinyColor.fromHSV() -> TinyColor.fromHSVColor(), .toHsv() -> .toHSVColor() * fix: missing deprecated method for TinyColor.fromHSV(), .toHsv() * docs: update readme using renamed TinyColor.fromColor(), TinyColor.fromHSVColor() * fix: update extensions on TInyColor.fromColor(), TinyColor.fromHSVColor(), .toHSVColor() * refactor: rename TinyColor.fromHSL() -> TinyColor.fromHSLColor(), .toHsl() -> .toHSLColor() * refactor: use .toHSLColor() reference over deprecated .toHsl() * feat: consolidate imports * feat: updated tests on renamed constructors and methods * style: formatting * docs: update changelog on renaming constructors and methods per Dart & Flutter naming conventions * docs: fix outdated readme * docs: update deprecated usage with TinyColor.fromColor() * fix: outdated usage of TinyColor() * refactor: adding .toColor() shortcut to return a Color clone instead of _color reference with fixes on .color
calvintam236
added a commit
that referenced
this pull request
Jun 16, 2022
calvintam236
added a commit
that referenced
this pull request
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.