Skip to content

If package publication partially or fully failed and --bail flag is not set to true, than there should be now success publication message #21

Closed
SkReD opened this issue Jun 10, 2022 · 0 comments · Fixed by #62
Labels
bug Something isn't working

Comments

@SkReD
Copy link
Contributor

SkReD commented Jun 10, 2022

Now if publication failed during npm publish command notification with success message still sending. Even if not packages published at all

This line https://github.com/Tinkoff/pvm/blob/master/src/plugins/core/publish/index.ts#L148 is always executed even if publishedPkgsStats contains errors

@SkReD SkReD added the bug Something isn't working label Jun 10, 2022
@SkReD SkReD changed the title If package publication partially of fully failed and --bail flag is not set to true, than notification should reflect that If package publication partially or fully failed and --bail flag is not set to true, than notification should reflect that Jun 10, 2022
@SkReD SkReD changed the title If package publication partially or fully failed and --bail flag is not set to true, than notification should reflect that If package publication partially or fully failed and --bail flag is not set to true, than there should be now success publication message Jun 10, 2022
@SkReD SkReD closed this as completed in #62 Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant