날짜 초기화 자동 프로세스 최종 [Toast 연결] #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
목표시간 초기화 프로세스 개선
Toast Message 구현 [SwiftUI]
minsangKang
approved these changes
Aug 4, 2024
|
|
||
| /// view의 사이즈를 알아내는 함수 | ||
| @ViewBuilder | ||
| func onReadSize(_ perform: @escaping (CGSize) -> Void) -> some View { |
Comment on lines
31
to
37
| let now = Date().setTime(hour: RecordsManager.resetHour, minute: 0, second: 0) | ||
| if now.hour < RecordsManager.resetHour { | ||
| /// 전 날 기록이 없고, 새벽에 들어오는 경우 | ||
| self.day = now.nextDay(offset: -1) | ||
| } else { | ||
| self.day = now | ||
| } |
There was a problem hiding this comment.
P1 (꼭 확인)
day 의 값이 H 시간이 반영된 날짜값이여야 합니다!
해당 로직으로는 Date 값에 H 시간이 반영되어 있지 않은 것 같아요!
There was a problem hiding this comment.
음.. 위 로직 자체가 잘못되었네요ㅠ
왜 저렇게 했는지 기억은 안나지만,, 수정했습니다
- 전 날 기록이 없고, 오늘 새벽에 들어왔는데 resetHour 이전 시간인 경우
- 전 날의 기록으로 생성 -> 생성할 때 H시간이 반영되도록!
| @@ -136,6 +140,7 @@ final class StopwatchVM { | |||
| RecordsManager.shared.recordTimes.reset() | |||
| self.updateDaily() | |||
| self.updateTimes() | |||
| ToastMessage.shared.show(type: .newRecord) | |||
| private func setting(_ type: ToastType) { | ||
| presenter.height = height | ||
| if !UIDevice.current.orientation.isLandscape { | ||
| presenter.height += UIApplication.shared.windows.first?.safeAreaInsets.top ?? 0 |
There was a problem hiding this comment.
P5 (의견)
safeAreaInsets.top 값의 경우 자주 사용될수도 있을 것 같다고 생각되네요
Extension 추가는 어떨까요?
extension UIApplication {
var safeAreaTop: CGFloat {
return UIApplication.shared.windows.first?.safeAreaInsets.bottom ?? 0
}
}
Comment on lines
45
to
51
| withAnimation(.easeIn(duration: 0.15)) { | ||
| yOffset = presenter.height + viewHeight | ||
| } completion: { | ||
| DispatchQueue.main.asyncAfter(deadline: .now()+1, execute: { | ||
| hide() | ||
| }) | ||
| } |
There was a problem hiding this comment.
최종 duration 수치를 조정해보면 좋겠습니다!
There was a problem hiding this comment.
최종적으로 논의된 수치로 반영했습니다!
https://www.notion.so/timertiti/Toast-Animation-25b9a4d3d8104176bfed617fb5deaeab?pvs=4
- newRecord -> createNewRecord - 내부 함수 사용시 self 키워드 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sub PR
변경사항
이번 PR에서는 아래 commit이 등록되었어요
3dc75e4: Daily의 day가 생성되는 로직을 변경 했어요!
5619883: ToastView가 iPad에서 두배가 되도록 로직을 추가했어요!
b9321d5: 날짜 초기화 시점에 맞춰 Toast.show()
ScreenShot
Toast는 애니메이션이 있어 영상으로 첨부합니다.
iPhone에서 세로모드, 가로모드
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-31.at.17.56.37.mp4
iphone_land.mov
Simulator.Screen.Recording.-.iPad.Pro.11-inch.4th.generation.-.2024-07-31.at.17.59.23.mp4
ipad_land.mov