dataflow/operators/core: add .partition() for StreamCore
#610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrosagg
force-pushed
the
partition-core
branch
2 times, most recently
from
6bf627b to
a9eeecc
Compare
antiguru
reviewed
Dec 17, 2024
| /// } | ||
| /// }); | ||
| /// ``` | ||
| fn partition<C2, D2, F>(&self, parts: u64, route: F) -> Vec<StreamCore<G, C2>> |
There was a problem hiding this comment.
Consider taking a container builder here instead!
There was a problem hiding this comment.
Good point! Changed to a container builder argument
5 tasks
Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
force-pushed
the
partition-core
branch
from
a9eeecc to
817dbb6
Compare
|
Looks good to me, thanks! |
Merged
antiguru
reviewed
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.