DNM: Remove Container::Item #538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiguru
commented
Nov 26, 2023
| @@ -45,11 +45,11 @@ pub trait Reclock<S: Scope> { | |||
| /// assert_eq!(extracted[1], (5, vec![4,5])); | |||
| /// assert_eq!(extracted[2], (8, vec![6,7,8])); | |||
| /// ``` | |||
| fn reclock<TC: Container<Item=()>>(&self, clock: &StreamCore<S, TC>) -> Self; | |||
There was a problem hiding this comment.
This is only looking for a progress stream, but requires a container because we have no other way to express its expectations.
| fn inspect_core<F>(&self, mut func: F) -> Self where F: FnMut(Result<(&G::Timestamp, &[D]), &[G::Timestamp]>) + 'static { | ||
| self.inspect_container(move |r| func(r.map(|(t, c)| (t, &c[..])))) | ||
| } | ||
| } | ||
|
|
||
| impl<G: Scope, C: Container> Inspect<G, Rc<C>> for StreamCore<G, Rc<C>> |
There was a problem hiding this comment.
This changes the semantics for inspecting Rc<C>, and I'm not sure we use this. It might be relevant for consuming streams of differential updates at some point, but at the moment it's Vec<Rc<Batch>> and not Rc<Container<Batch>> for some unspecified container.
It's not used, and unclear as to what it should communicate. Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru
force-pushed
the
container_no_item
branch
from
efb29a0
to
0cd3bd6
Compare
|
Superseded by #541 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not used, and unclear as to what it should communicate. Let's talk this over!