Define ConsolidateLayout for FlatStack in terms of MergerChunk #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiguru
force-pushed
the
consolidate_layout_merger_chunk
branch
from
b9fb3d0
to
88aaa0e
Compare
Signed-off-by: Moritz Hoffmann <[email protected]>
I'm not sure about this. It's a gross change as it pulls behavior across unrelated places, but I'm also not sure how to implement without effectively duplicating the `MergerChunk`. What might work is a trait that extends `MergerChunk` and just adds the `cmp_without_diff` function. Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru
force-pushed
the
consolidate_layout_merger_chunk
branch
from
88aaa0e
to
04a2446
Compare
|
Superseded by #518 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure about this. It's a gross change as it pulls behavior across
unrelated places, but I'm also not sure how to implement without
effectively duplicating the
MergerChunk. What might work is a trait thatextends
MergerChunkand just adds thecmp_without_difffunction.The main purpose for this to exist is so that I can use
ConsolidateLayoutwith other regions than the single implementation, otherwise its impossible to have a more specific implementation, for example to support different kinds of regions.Signed-off-by: Moritz Hoffmann [email protected]