Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define flat container types in terms of regions #514

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

antiguru
Copy link
Member

@antiguru antiguru commented Jun 20, 2024

Define flat container spines in terms of regions instead of concrete types. Add a FlatKeySpineDefault and similarly a FlatValSpineDefault type definition that defers to the Containerized trait to obtain the region of a type. This change tidies up some trait implementations where they in the past were defined in terms of concrete (owned) types instead of regions. This also allows for greater reuse of the region-based types because someone else can define a different Containerized trait but still use the region-based types.

I'm not too happy about the *Default names because it doesn't convey the meaning, but I haven't thought of a better name.

Copy link
Member

@frankmcsherry frankmcsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@frankmcsherry frankmcsherry merged commit 9fac226 into TimelyDataflow:master Jun 24, 2024
7 checks passed
antiguru added a commit to MaterializeInc/differential-dataflow that referenced this pull request Jun 24, 2024
Define flat container types in terms of regions (TimelyDataflow#514)
@antiguru antiguru deleted the flat_parameters branch June 24, 2024 19:42
This was referenced Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants