Remove 'static requirement from difference traits
#501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankmcsherry
force-pushed
the
lifetimed_differences
branch
from
fc87f61
to
b7adba2
Compare
antiguru
approved these changes
May 27, 2024
frankmcsherry
force-pushed
the
lifetimed_differences
branch
from
b7adba2
to
903ea35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our difference traits,
Semigroup,Monoid, andAbelian, have been defined to requireData, which has been a helpful catch-all trait that includes'static. However, it is reasonable to want to implement these traits for lifetimed data, for example aCow<'a, Diff>type.This PR replaces
DatawithClonein the requirements for the difference traits, and moves the'staticand occasionallyOrdrequirements to those locations where they are required. This is a bit noisier, but I think a bit more "accurate".