Consolidate as part of TraceFrontier map_times
#490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TraceFrontierbrings all times up to a frontier (and discards updates at times beyond another frontier). This introduces the potential for consolidation, butmap_timesdoes not consolidate updates and relies on the interested user to do this. Recent experience indicates that most users are not aware of this, including your correspondent. This fix introduces consolidation as part ofmap_times, and is meant to broadly insulate folks who do not actively consolidate, which includes some parts of DD itself (seemingly justCursor::to_vec; other users seem to have a prompt consolidation).cc: @antiguru