First cut at neu key-only spine #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiguru
approved these changes
Nov 30, 2023
Comment on lines
+886
to
+888
| self.result.updates.push(item); | ||
| } |
There was a problem hiding this comment.
(Not for this PR) We should allow to pre-size updates so it won't have to reallocate on push.
There was a problem hiding this comment.
Ah, I hoped it was. Isn't it formed with_capacity in each of the constructors?
There was a problem hiding this comment.
Note: very possibly due to the optimization that may go from large to small to large again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First cut at
ord_neu::OrdKeySpine. Lots of copy/pasta, and opportunities for bugs. Though, many of them caught because thevalsnames went away. Should do some testing. Also, the PR removesordandlayers, which is an opinionated take. At least, comments them out and sets default traces toord_neu. We can delete once we are more certain.