Further trait reorganization #427
Conversation
|
Oh oops, it also adds a |
| inner: Vec::with_capacity(size), | ||
| } | ||
| } | ||
| fn reserve(&mut self, _additional: usize) { |
There was a problem hiding this comment.
Note to @antiguru: we could have a slightly better implementation here to pre-size the local part of self, but I can't recall the available apis out of my head.
| } | ||
|
|
||
| // The `ToOwned` requirement exists to satisfy `self.reserve_items`, who must for now | ||
| // be presented with the actual contained type, rather than a type that borrows into it. |
There was a problem hiding this comment.
We should revisit the type requirements on region and timely stack!
There was a problem hiding this comment.
Right! I'm not sure if it really helps here, but e.g. if I have a bunch of Vec<u8> and you are able to only maintain [u8] shaped data, that could help. Or we could conclude that this type does not do that, and not be too stressed! :D
This PR moves
BatchContainerandOrdOffsetout of thelayersmodule which is specific to Trie implementations, and in to theimplementationsmodule, which seems more appropriate.It also experiments a bit with the
BatchContainertrait, allowingItemto be unsized, and supportingpushandcopy_sliceonly whenT: ToOwned. This is .. unfortunately a restriction rather than a pure generalization; to implementToOwnedyou have to be able to clone yourself, even though we don't need this.Up for discussion, but I think based on the vibes around containers, and their non-ownership-providing nature, this might be ok.
cc: @antiguru