Implement OrdValBatch
without retain_from
#419
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a re-implementation of
OrdValBatch
with a few properties:Vec<(Time, Diff)>
,Vec<(Time, Diff)>
representations (RLE).There might be other things to like about it. In the fullness of time it would mean we could remove the
trace/layers
module, because the direct implementations aren't much more complicated, and in some ways are much simpler because of their directness.This PR passes tests, but it probably wants a fair bit of exercise to see if it exactly tracks the existing implementations.
cc: @antiguru