Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize generic arguments as layouts #415

Merged
merged 6 commits into from
Nov 12, 2023
Merged

Organize generic arguments as layouts #415

merged 6 commits into from
Nov 12, 2023

Conversation

frankmcsherry
Copy link
Member

@frankmcsherry frankmcsherry commented Nov 11, 2023

A brainstorming PR to see what it looks like to organize various walls of generic parameters behind types that provide coherent associated type guidance. Many type signatures and where clause lengths decrease. The main downside is that I struggled to maintain the constraint that O must have its TryInto::Err variants implement Debug. I didn't try too hard, but all that is lost is naming a specific number that cannot be cast should it error (it shouldn't!).

There is still all of OrdKey* to do, but I thought I'd put this up to look at it.

cc: @antiguru, @petrosagg

@frankmcsherry frankmcsherry merged commit abad1b4 into master Nov 12, 2023
2 checks passed
@frankmcsherry frankmcsherry deleted the ord_cleanup branch November 12, 2023 20:03
This was referenced Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant