Generalize TraceFrontier with upper frontier
#370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankmcsherry
force-pushed
the
import_improvements
branch
from
dbc4917
to
1c29072
Compare
frankmcsherry
force-pushed
the
import_improvements
branch
from
1c29072
to
1b4717d
Compare
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
upper: Antichain<T>frontier toTraceFrontier, generalizing it from the time interval[since, ...)to[since, upper). One option forupperis the empty frontier, which is semantically identical. This generalization allows one to import and use an arrangement on an intentionally narrowed interval of time, for example such as when one knows that changes at times greater than or equal toupperare of no interest.This PR causes the import operator to drop its capabilities at this point, so that it may shut down the dataflow. This does risk miscommunicating that the trace is now "complete", but only in the same sense that pressing the returned
ShutdownButtondoes, so this is judged to be not a new risk.