make capture::source's token thread-safe #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
antiguru
pushed a commit
to antiguru/differential-dataflow
that referenced
this pull request
May 11, 2022
* make capture::source's token thread-safe * clean up capability dropping more * break tuple out into variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of resolving: MaterializeInc/materialize#11987, we
in general, thread-safety comes at a small perf cost, but in this case, the sync activator is only called once, and the Arc is never cloned, so it will not be a measurable difference, other than the
upgradecosting one atomic load each run. This is a strictly more general api now! TheSend + Synccan be coerced away if need beI can clean this up once I make a Sync version of
ActivatorOnDropin the timely repo!tested locally, token drop does in fact clear the local token vector