Memory alloc improvements #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moritz Hoffmann <[email protected]>
src/trace/mod.rs
Outdated
Comment on lines
169
to
170
| target.clone_from(batch.upper()); | ||
| target.clear(); | ||
| target.extend(batch.upper().iter().cloned()); |
There was a problem hiding this comment.
This is a bit surprising as an improvement. I think clone_from() is supposed to do this already.
There was a problem hiding this comment.
I removed this change as it should be superseded by frankmcsherry/timely-dataflow@7f5b8b7
There was a problem hiding this comment.
For posterity: clone_from() does not do the expected thing; the derived implementation calls clone() rather than clone_from().
Signed-off-by: Moritz Hoffmann <[email protected]>
This commit changes the TraceAgent to keep a buffer for temporary antichains around, which is used for setting the logical and physical compaction. The upside is that it avoids temporary allocations, but on the downside it keeps another antichain around. This should be fine, unless there is a defective use case where the size of the antichain grows significantly and the potentially unused memory will not be reclaimed anymore. Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru
force-pushed
the
memory_alloc_improvements
branch
from
a2d1d60
to
dc49c33
Compare
Signed-off-by: Moritz Hoffmann <[email protected]>
frankmcsherry
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of small improvements to bypass the memory allocator when possible.