Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of timely_sort crate #313

Merged
merged 2 commits into from
Mar 10, 2021

Conversation

frankmcsherry
Copy link
Member

@frankmcsherry frankmcsherry commented Mar 9, 2021

The timely_sort crate presented a way to get a u64 either in the days before Into<u64> or before I knew about Into<u64>. In any case, that was the only requirement for the use in differential dataflow, and instances of timely_sort::Unsigned have been replaced with Into<u64> and calls to as_u64() replaced with into().

Edit: this PR also sneakily deletes a bunch of other content from hashable.rs that was effectively dead code, at least in the context of this repository. Apologies to anyone who found them useful outside of differential dataflow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant