Race in Dogs^3 frontiers #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #183, there is a race in the dogsdogsdogs project. This PR fixes it!
It turns out to be pretty simple once diagnosed: the traces shared by all of the operators call
advance_byto allow the trace to compact, and they are supposed to use a frontier less or equal to the times they will need in the future, less the trace race ahead of the diffs. In fact, we were using only the corresponding input frontier, when we should have merged that information with stashed updates that we had not yet processed.With that fix in place, @ryhzyk's
error.rsexample produces two triangles 10/10 times for me.