Add collection::concatenate #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzhyk
added a commit
to vmware/differential-datalog
that referenced
this pull request
Apr 26, 2019
We used to use `Collection::concat()` to concatenate multiple rules for a collection one-by-one. Turns out, this is extremely wasteful, as each concat operator ends up copying both its input collections. A better way to do this is with the lower-level `Stream::concatenate` API from timely. @frankmcsherry added a convenience wrapper for this API to `collection.rs`: TimelyDataflow/differential-dataflow#170, but until this change makes it to a released version of DD I created a copy of this function in `program.rs`
ryzhyk
added a commit
to vmware/differential-datalog
that referenced
this pull request
Apr 26, 2019
We used to use `Collection::concat()` to concatenate multiple rules for a collection one-by-one. Turns out, this is extremely wasteful, as each concat operator ends up copying both its input collections. A better way to do this is with the lower-level `Stream::concatenate` API from timely. @frankmcsherry added a convenience wrapper for this API to `collection.rs`: TimelyDataflow/differential-dataflow#170, but until this change makes it to a released version of DD I created a copy of this function in `program.rs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a free method
concatenateto thecollectionmodule. The intent is to provide easier access to multi-collection concatenation, with currently either requires a chain ofconcatcalls, or dropping into timely dataflow to use its multi-stream concatenation.This PR also adds a
Collection::concatenatemethod if you don't have a scope to start from.